netdev - Re: [PATCH RFC ipsec-next] xfrm: Check Reverse-Mark Lookup Before ADDSA/DELSA

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20180727073322.uu7fn2edy5fwrs63@gauss3.secunet.de>
Date:   Fri, 27 Jul 2018 09:33:22 +0200
From:   Steffen Klassert <steffen.klassert@...unet.com>
To:     Nathan Harold <nharold@...gle.com>
CC:     <netdev@...r.kernel.org>
Subject: Re: [PATCH RFC ipsec-next] xfrm: Check Reverse-Mark Lookup Before
 ADDSA/DELSA

On Wed, Jul 25, 2018 at 03:36:47PM -0700, Nathan Harold wrote:
> 
> diff --git a/net/xfrm/xfrm_state.c b/net/xfrm/xfrm_state.c
> index b669262682c9..ee212a7c91a9 100644
> --- a/net/xfrm/xfrm_state.c
> +++ b/net/xfrm/xfrm_state.c
> @@ -815,10 +815,10 @@ xfrm_init_tempstate(struct xfrm_state *x, const struct flowi *fl,
>  	afinfo->init_temprop(x, tmpl, daddr, saddr);
>  }
>  
> -static struct xfrm_state *__xfrm_state_lookup(struct net *net, u32 mark,
> -					      const xfrm_address_t *daddr,
> -					      __be32 spi, u8 proto,
> -					      unsigned short family)
> +static struct xfrm_state *
> +__xfrm_state_lookup(struct net *net, u32 mark, u32 mask,
> +		    const xfrm_address_t *daddr,
> +		    __be32 spi, u8 proto, unsigned short family)

The argument list of these functions are getting longer and longer.
Can't you just put in a pointer to struct xfrm_mark and dereference
inside the function?

Looks good otherwise.