[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-Id: <20180729.130022.1331103687380303425.davem@davemloft.net>
Date: Sun, 29 Jul 2018 13:00:22 -0700 (PDT)
From: David Miller <davem@...emloft.net>
To: petrm@...lanox.com
Cc: netdev@...r.kernel.org, linux-kselftest@...r.kernel.org,
jiri@...lanox.com, idosch@...lanox.com, shuah@...nel.org
Subject: Re: [PATCH net-next] selftests: mlxsw: qos_dscp_bridge: Fix
From: Petr Machata <petrm@...lanox.com>
Date: Sat, 28 Jul 2018 00:48:13 +0200
> There are two problems in this test case:
>
> - When indexing in bash associative array, the subscript is interpreted as
> string, not as a variable name to be expanded.
>
> - The keys stored to t0s and t1s are not DSCP values, but priority +
> base (i.e. the logical DSCP value, not the full bitfield value).
>
> In combination these two bugs conspire to make the test just work,
> except it doesn't really test anything and always passes.
>
> Fix the above two problems in obvious manner.
>
> Signed-off-by: Petr Machata <petrm@...lanox.com>
Applied, thanks.
Powered by blists - more mailing lists