netdev - Re: [PATCH net] ipv4: remove BUG_ON() from fib_compute_spec

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20180728.190702.1921184748389867883.davem@davemloft.net>
Date:   Sat, 28 Jul 2018 19:07:02 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     lorenzo.bianconi@...hat.com
Cc:     netdev@...r.kernel.org
Subject: Re: [PATCH net] ipv4: remove BUG_ON() from fib_compute_spec_dst

From: Lorenzo Bianconi <lorenzo.bianconi@...hat.com>
Date: Fri, 27 Jul 2018 18:15:46 +0200

> Remove BUG_ON() from fib_compute_spec_dst routine and check
> in_dev pointer during flowi4 data structure initialization.
> fib_compute_spec_dst routine can be run concurrently with device removal
> where ip_ptr net_device pointer is set to NULL. This can happen
> if userspace enables pkt info on UDP rx socket and the device
> is removed while traffic is flowing
> 
> Fixes: 35ebf65e851c ("ipv4: Create and use fib_compute_spec_dst() helper")
> Signed-off-by: Lorenzo Bianconi <lorenzo.bianconi@...hat.com>

Applied and queued up for -stable, thank you.