netdev - Re: [PATCH net-next 1/2] tcp: call tcp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CANn89iK4KLHww-R2JmNr-tYVcUWevq6ceFQW0qE2mJCsq6eL-g@mail.gmail.com>
Date:   Mon, 30 Jul 2018 08:56:35 -0700
From:   Eric Dumazet <edumazet@...gle.com>
To:     Yafang Shao <laoar.shao@...il.com>,
        Brendan Gregg <bgregg@...flix.com>
Cc:     David Miller <davem@...emloft.net>,
        netdev <netdev@...r.kernel.org>,
        LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH net-next 1/2] tcp: call tcp_drop() in tcp collapse

On Sun, Jul 29, 2018 at 10:40 PM Yafang Shao <laoar.shao@...il.com> wrote:

> Should we put NET_INC_STATS(sock_net(sk),  mib_idx) into the funtion
> tcp_drop() ?
> Then we could easily relate the sk_drops with the SNMP counters.
>
> Something like that,
>
>     static void tcp_drop(struct sock *sk, struct sk_buff *skb, int mib_idx)
>     {
>         int segs = max_t(u16, 1, skb_shinfo(skb)->gso_segs);
>
>         atomic_add(segs, &sk->sk_drops);
>         NET_ADD_STATS(sock_net(sk), mib_idx, segs);
>         __kfree_skb(skb);
>     }

We had a discussion during netconf, and Brendan Gregg was working on
an idea like that,
so that distinct events could be traced/reported.

I prefer letting Brendan submit his patch, which not only refactors
things, but add new functionality.

Thanks.