netdev - Re: [net-next v1] net/ipv6: allow any source address for sendmsg pktinfo with ip_nonlocal

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20180730.090841.1368485183443140606.davem@davemloft.net>
Date:   Mon, 30 Jul 2018 09:08:41 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     vincent@...nat.im
Cc:     kuznet@....inr.ac.ru, yoshfuji@...ux-ipv6.org,
        netdev@...r.kernel.org, tom@...bertland.com
Subject: Re: [net-next v1] net/ipv6: allow any source address for sendmsg
 pktinfo with ip_nonlocal_bind

From: Vincent Bernat <vincent@...nat.im>
Date: Mon, 30 Jul 2018 08:08:12 +0200

>  ❦ 29 juillet 2018 12:28 -0700, David Miller <davem@...emloft.net> :
> 
>>> When freebind feature is set of an IPv6 socket, any source address can
>>> be used when sending UDP datagrams using IPv6 PKTINFO ancillary
>>> message. Global non-local bind feature was added in commit
>>> 35a256fee52c ("ipv6: Nonlocal bind") for IPv6. This commit also allows
>>> IPv6 source address spoofing when non-local bind feature is enabled.
>>> 
>>> Signed-off-by: Vincent Bernat <vincent@...nat.im>
>>
>> This definitely seems to make sense.  And is consistent with the other
>> tests involving freebind and transparent.
>>
>> This test involving ip_nonlocal_bind, freeebind, and transparent happens
>> in several locations.  Perhaps we should add a helper function for
>> this?
> 
> Yes, I can do that. Should I also include one for SCTP?

If the helper for SCTP needs to be different and thus will only be
used in one place, probably not.  The whole idea is to remove
duplicated code, and prevent someone in the future from forgetting
to test all three values in these situations.

Thanks.