netdev - Re: [PATCH] phy: Move "device present" masks earlier in file

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20180730.092319.1806492645215935692.davem@davemloft.net>
Date:   Mon, 30 Jul 2018 09:23:19 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     rpjday@...shcourse.ca
Cc:     netdev@...r.kernel.org, andrew@...n.ch, f.fainelli@...il.com
Subject: Re: [PATCH] phy: Move "device present" masks earlier in file

From: "Robert P. J. Day" <rpjday@...shcourse.ca>
Date: Fri, 27 Jul 2018 15:32:20 -0400 (EDT)

> Move the "device present" mask bits up immediately after the MMD
> device definitions, since it makes no sense to have them further down
> in the file.
> 
> This is purely a cosmetic change for readability.
> 
> Signed-off-by: Robert P. J. Day <rpjday@...shcourse.ca>

Sorry, but this actually kills readability.

This area of this header file is a series of collections of register
bit definitions.  One for each register.

You are moving the device present register definitions out of that
area.

It makes no sense at all.

I'm not applying this, sorry.