netdev - Re: [PATCH net-next v5 3/4] net/tc: introduce TC_ACT

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20180730.093100.1043667653536689097.davem@davemloft.net>
Date:   Mon, 30 Jul 2018 09:31:00 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     jiri@...nulli.us
Cc:     pabeni@...hat.com, netdev@...r.kernel.org, jhs@...atatu.com,
        xiyou.wangcong@...il.com, daniel@...earbox.net,
        marcelo.leitner@...il.com, eyal.birger@...il.com
Subject: Re: [PATCH net-next v5 3/4] net/tc: introduce TC_ACT_REINSERT.

From: Jiri Pirko <jiri@...nulli.us>
Date: Mon, 30 Jul 2018 14:40:13 +0200

> Oh, another nitpick: The changelog should go under "---" line. That way,
> the maintainer does not have to deal with it during apply (git apply
> will cut it out).

I actually like the changelog to be _IN_ the commit message.

It's useful information that helps someone investigating history
in the tree later.

Please do not tell people to pull changelogs out of the commit
message, thank you.  I've been telling them to do the exact
opposite.