netdev - Re: [PATCH net-next v7] net/tls: Use socket data

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20180730.094207.1618887888310467887.davem@davemloft.net>
Date:   Mon, 30 Jul 2018 09:42:07 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     vakul.garg@....com
Cc:     netdev@...r.kernel.org, borisp@...lanox.com, aviadye@...lanox.com,
        davejwatson@...com
Subject: Re: [PATCH net-next v7] net/tls: Use socket data_ready callback on
 record availability

From: Vakul Garg <vakul.garg@....com>
Date: Mon, 30 Jul 2018 16:08:33 +0530

> On receipt of a complete tls record, use socket's saved data_ready
> callback instead of state_change callback. In function tls_queue(),
> the TLS record is queued in encrypted state. But the decryption
> happen inline when tls_sw_recvmsg() or tls_sw_splice_read() get invoked.
> So it should be ok to notify the waiting context about the availability
> of data as soon as we could collect a full TLS record. For new data
> availability notification, sk_data_ready callback is more appropriate.
> It points to sock_def_readable() which wakes up specifically for EPOLLIN
> event. This is in contrast to the socket callback sk_state_change which
> points to sock_def_wakeup() which issues a wakeup unconditionally
> (without event mask).
> 
> Signed-off-by: Vakul Garg <vakul.garg@....com>
> ---
> v6->v7: Improved the commit message to contain the detailed reasoning.
> (The same analysis was shared on the mail list.)

Applied.