netdev - Re: [PATCH net] net/ipv6: fix metrics leak

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20180730.094637.1751168123955659634.davem@davemloft.net>
Date:   Mon, 30 Jul 2018 09:46:37 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     sd@...asysnail.net
Cc:     netdev@...r.kernel.org, dsahern@...il.com
Subject: Re: [PATCH net] net/ipv6: fix metrics leak

From: Sabrina Dubroca <sd@...asysnail.net>
Date: Mon, 30 Jul 2018 16:23:10 +0200

> Since commit d4ead6b34b67 ("net/ipv6: move metrics from dst to
> rt6_info"), ipv6 metrics are shared and refcounted. rt6_set_from()
> assigns the rt->from pointer and increases the refcount on from's
> metrics. This reference is never released.
> 
> Introduce the fib6_metrics_release() helper and use it to release the
> metrics.
> 
> Fixes: d4ead6b34b67 ("net/ipv6: move metrics from dst to rt6_info")
> Signed-off-by: Sabrina Dubroca <sd@...asysnail.net>

Looks good, applied, thanks.