netdev - Re: [PATCH v2 6/7] net: phy: Add support to configure clock in Broadcom iProc mdio mux

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d19bb673-9088-bbee-ce9f-f2a4d8f404bf@broadcom.com>
Date:   Mon, 30 Jul 2018 09:49:48 -0700
From:   Arun Parameswaran <arun.parameswaran@...adcom.com>
To:     Andrew Lunn <andrew@...n.ch>
Cc:     "David S. Miller" <davem@...emloft.net>,
        Florian Fainelli <f.fainelli@...il.com>,
        Rob Herring <robh+dt@...nel.org>,
        Mark Rutland <mark.rutland@....com>,
        Ray Jui <rjui@...adcom.com>,
        Scott Branden <sbranden@...adcom.com>,
        Catalin Marinas <catalin.marinas@....com>,
        Will Deacon <will.deacon@....com>, netdev@...r.kernel.org,
        devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        linux-kernel@...r.kernel.org, bcm-kernel-feedback-list@...adcom.com
Subject: Re: [PATCH v2 6/7] net: phy: Add support to configure clock in
 Broadcom iProc mdio mux

Hi Andrew,

On 18-07-28 02:22 PM, Andrew Lunn wrote:
>> @@ -198,10 +219,22 @@ static int mdio_mux_iproc_probe(struct platform_device *pdev)
>>  		return PTR_ERR(md->base);
>>  	}
>>  
>> +	md->core_clk = devm_clk_get(&pdev->dev, NULL);
>> +	if (IS_ERR(md->core_clk)) {
>> +		md->core_clk = NULL;
>> +	} else {
>> +		rc = clk_prepare_enable(md->core_clk);
>> +		if (rc) {
>> +			dev_err(&pdev->dev, "failed to enable core clk\n");
>> +			return rc;
>> +		}
>> +	}
>> +
>>  	md->mii_bus = mdiobus_alloc();
>>  	if (!md->mii_bus) {
>>  		dev_err(&pdev->dev, "mdiomux bus alloc failed\n");
>> -		return -ENOMEM;
>> +		rc = -ENOMEM;
>> +		goto out;
> 
> Hi Arun
> 
> There is a devm_mdiobus_alloc() which could make the cleanup on error
> simple.
> 
Should I do this as a separate patch ?

Thanks
Arun
>>  	}
>>  
>>  	bus = md->mii_bus;
>> @@ -217,7 +250,7 @@ static int mdio_mux_iproc_probe(struct platform_device *pdev)
>>  	rc = mdiobus_register(bus);
>>  	if (rc) {
>>  		dev_err(&pdev->dev, "mdiomux registration failed\n");
>> -		goto out;
>> +		goto out_alloc;
>>  	}
>>  
>>  	platform_set_drvdata(pdev, md);
>> @@ -236,8 +269,11 @@ static int mdio_mux_iproc_probe(struct platform_device *pdev)
>>  
>>  out_register:
>>  	mdiobus_unregister(bus);
>> -out:
>> +out_alloc:
>>  	mdiobus_free(bus);
>> +out:
>> +	if (md->core_clk)
>> +		clk_disable_unprepare(md->core_clk);
>>  	return rc;
>>  }
> 
>    Andrew
>