netdev - Re: [PATCH 00/18] xfrm: Add compat layer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1532972360.2679.32.camel@arista.com>
Date:   Mon, 30 Jul 2018 18:39:20 +0100
From:   Dmitry Safonov <dima@...sta.com>
To:     David Miller <davem@...emloft.net>
Cc:     nharold@...gle.com, fw@...len.de, steffen.klassert@...unet.com,
        linux-kernel@...r.kernel.org, herbert@...dor.apana.org.au,
        0x7f454c46@...il.com, netdev@...r.kernel.org, luto@...nel.org,
        ard.biesheuvel@...aro.org, hpa@...or.com, mingo@...hat.com,
        john.stultz@...aro.org, kirill.shutemov@...ux.intel.com,
        oleg@...hat.com, sboyd@...nel.org, rostedt@...dmis.org,
        tglx@...utronix.de, x86@...nel.org, linux-efi@...r.kernel.org,
        akpm@...ux-foundation.org, gregkh@...uxfoundation.org,
        mchehab+samsung@...nel.org, shuah@...nel.org,
        linux-kselftest@...r.kernel.org, eparis@...hat.com,
        kadlec@...ckhole.kfki.hu, pablo@...filter.org, paul@...l-moore.com,
        coreteam@...filter.org, linux-audit@...hat.com,
        netfilter-devel@...r.kernel.org, fan.du@...el.com
Subject: Re: [PATCH 00/18] xfrm: Add compat layer

On Sat, 2018-07-28 at 14:18 -0700, David Miller wrote:
> From: Dmitry Safonov <dima@...sta.com>
> Date: Sat, 28 Jul 2018 17:26:55 +0100
> 
> > Well, I think, I'll rework my patches set according to critics and
> > separate compat xfrm layer. I've already a selftest to check that
> 32/64
> > bit xfrm works - so the most time-taking part is done.
> 
> The way you've done the compat structures using __packed is only
> going
> to work on x86, just FYI.

Thanks for pointing, so I'll probably cover it under something like
HAS_COMPAT_XFRM.
(if there isn't any better idea).

> The "32-bit alignment for 64-bit objects" thing x86 has is very much
> not universal amongst ABIs having 32-bit and 64-bit variants.

-- 
Thanks,
             Dmitry