netdev - Re: [PATCH] net: remove bogus RCU annotations on socket.wq

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <bd0e18ee-c3be-fef2-b2b8-3a2ad576f765@gmail.com>
Date:   Mon, 30 Jul 2018 15:23:06 -0700
From:   Eric Dumazet <eric.dumazet@...il.com>
To:     Christoph Hellwig <hch@....de>, Eric Dumazet <edumazet@...gle.com>,
        "Paul E. McKenney" <paulmck@...ux.vnet.ibm.com>,
        netdev@...r.kernel.org
Cc:     linux-kernel@...r.kernel.org
Subject: Re: [PATCH] net: remove bogus RCU annotations on socket.wq



On 07/30/2018 12:45 AM, Christoph Hellwig wrote:
> We never use RCU protection for it, just a lot of cargo-cult
> rcu_deference_protects calls.
> 
> Note that we do keep the kfree_rcu call for it, as the references through
> struct sock are RCU protected and thus might require a grace period before
> freeing.
> 
> Signed-off-by: Christoph Hellwig <hch@....de>

Reviewed-by: Eric Dumazet <edumazet@...gle.com>

Thanks.