netdev - Re: [PATCH] net: remove bogus RCU annotations on socket.wq

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20180731.124053.2701966560858042.davem@davemloft.net>
Date:   Tue, 31 Jul 2018 12:40:53 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     hch@....de
Cc:     edumazet@...gle.com, paulmck@...ux.vnet.ibm.com,
        netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] net: remove bogus RCU annotations on socket.wq

From: Christoph Hellwig <hch@....de>
Date: Mon, 30 Jul 2018 09:45:07 +0200

> We never use RCU protection for it, just a lot of cargo-cult
> rcu_deference_protects calls.
> 
> Note that we do keep the kfree_rcu call for it, as the references through
> struct sock are RCU protected and thus might require a grace period before
> freeing.
> 
> Signed-off-by: Christoph Hellwig <hch@....de>

Applied to net-next, thanks.