netdev - Re: [PATCH bpf-next] lwt_bpf: remove unnecessary rcu_read_lock in run_lwt

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <8ce66947-8959-78a6-7ac9-8df236045ecb@iogearbox.net>
Date:   Tue, 31 Jul 2018 09:27:41 +0200
From:   Daniel Borkmann <daniel@...earbox.net>
To:     Taehee Yoo <ap420073@...il.com>, ast@...nel.org
Cc:     netdev@...r.kernel.org
Subject: Re: [PATCH bpf-next] lwt_bpf: remove unnecessary rcu_read_lock in
 run_lwt_bpf

On 07/30/2018 03:22 PM, Taehee Yoo wrote:
> run_lwt_bpf is called by bpf_{input/output/xmit}.
> These functions are already protected by rcu_read_lock.
> because lwtunnel_{input/output/xmit} holds rcu_read_lock
> and then calls bpf_{input/output/xmit}.
> So that rcu_read_lock in the run_lwt_bpf is unnecessary.
> 
> Signed-off-by: Taehee Yoo <ap420073@...il.com>

Applied to bpf-next, thanks Taehee!