netdev - Re: [PATCH net-next 0/3] xsk: improvements to RX queue check and replace

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <60ce1aab-5a6f-8d9c-e3d0-cc79fb15953d@iogearbox.net>
Date:   Tue, 31 Jul 2018 09:50:12 +0200
From:   Daniel Borkmann <daniel@...earbox.net>
To:     Jakub Kicinski <jakub.kicinski@...ronome.com>, davem@...emloft.net,
        alexei.starovoitov@...il.com
Cc:     netdev@...r.kernel.org, oss-drivers@...ronome.com,
        bjorn.topel@...el.com
Subject: Re: [PATCH net-next 0/3] xsk: improvements to RX queue check and
 replace

On 07/31/2018 05:43 AM, Jakub Kicinski wrote:
> Hi!
> 
> First 3 patches of my recent RFC.  The first one make the check against
> real_num_rx_queues slightly more reliable, while the latter two redefine
> XDP_QUERY_XSK_UMEM slightly to disallow replacing UMEM in the driver at
> the stack level.
> 
> I'm not sure where this lays on the bpf vs net trees scale, but there
> should be no conflicts with either tree.

I'm fine either way, in any case, series looks good to me:

Acked-by: Daniel Borkmann <daniel@...earbox.net>

> Jakub Kicinski (3):
>   net: update real_num_rx_queues even when !CONFIG_SYSFS
>   xsk: refactor xdp_umem_assign_dev()
>   xsk: don't allow umem replace at stack level
> 
>  include/linux/netdevice.h | 10 +++---
>  net/xdp/xdp_umem.c        | 70 +++++++++++++++++++++++----------------
>  2 files changed, 47 insertions(+), 33 deletions(-)
>