netdev - Re: [PATCH] HID: Bluetooth: hidp: buffer overflow in hidp_process

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 1 Aug 2018 19:09:26 +0200
From:   Greg KH <gregkh@...uxfoundation.org>
To:     Mark Salyzyn <salyzyn@...roid.com>
Cc:     linux-kernel@...r.kernel.org,
        Marcel Holtmann <marcel@...tmann.org>,
        Johan Hedberg <johan.hedberg@...il.com>,
        "David S. Miller" <davem@...emloft.net>,
        Kees Cook <keescook@...omium.org>,
        Benjamin Tissoires <benjamin.tissoires@...hat.com>,
        linux-bluetooth@...r.kernel.org, netdev@...r.kernel.org,
        stable <stable@...r.kernel.org>, kernel-team@...roid.com,
        Jiri Kosina <jkosina@...e.cz>
Subject: Re: [PATCH] HID: Bluetooth: hidp: buffer overflow in
 hidp_process_report

On Wed, Aug 01, 2018 at 09:41:04AM -0700, Mark Salyzyn wrote:
> On 08/01/2018 09:37 AM, Greg KH wrote:
> > On Tue, Jul 31, 2018 at 03:02:13PM -0700, Mark Salyzyn wrote:
> > > CVE-2018-9363
> > > 
> > > The buffer length is unsigned at all layers, but gets cast to int and
> > > checked in hidp_process_report and can lead to a buffer overflow.
> > > Switch len parameter to unsigned int to resolve issue.
> > > 
> > > This affects 3.18 and newer kernels.
> > > 
> > > Signed-off-by: Mark Salyzyn <salyzyn@...roid.com>
> > > Fixes: a4b1b5877b514b276f0f31efe02388a9c2836728 ("HID: Bluetooth: hidp: make sure input buffers are big enough")
> > > Cc: Marcel Holtmann <marcel@...tmann.org>
> > > Cc: Johan Hedberg <johan.hedberg@...il.com>
> > > Cc: "David S. Miller" <davem@...emloft.net>
> > > Cc: Kees Cook <keescook@...omium.org>
> > > Cc: Benjamin Tissoires <benjamin.tissoires@...hat.com>
> > > Cc: linux-bluetooth@...r.kernel.org
> > > Cc: netdev@...r.kernel.org
> > > Cc: linux-kernel@...r.kernel.org
> > > Cc: security@...nel.org
> > > Cc: kernel-team@...roid.com
> > Nit, you only need to bother security@ if you do not have a fix and need
> > to figure out one.
> 
> Thanks, I thought anything with a CVE was to go there according to netdev
> FAQ (dropped security from response list).
> > Also, you forgot to cc: stable@...r.kernel.org to be included in older
> > kernel releases :(
> netdev FAQ said to _not_ copy stable, I am so confused ;-{ (added stable to
> response list b/c patch is now taken into bluetooth-next)

Ah, well, bluetooth is a bit not normal here, usually stuff that ends up
in a subsystem tree before netdev needs to have a cc: stable on it for
me to catch it.  Hopefully the bluetooth maintainers are on it :)

thanks,

greg k-h