netdev - Re: [Patch net-next] net: hns3: fix return value error while hclge_cmd_csq

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20180801.100332.1084702659051147259.davem@davemloft.net>
Date:   Wed, 01 Aug 2018 10:03:32 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     tanhuazhong@...wei.com
Cc:     netdev@...r.kernel.org, linuxarm@...wei.com
Subject: Re: [Patch net-next] net: hns3: fix return value error while
 hclge_cmd_csq_clean failed

From: Huazhong Tan <tanhuazhong@...wei.com>
Date: Wed, 1 Aug 2018 17:53:28 +0800

> From: fredalu <fredalu@...h.net>
> 
> While cleaning the command queue, the value of the HEAD register is not
> in the range of next_to_clean and next_to_use, meaning that this value
> is invalid. This also means that there is a hardware error and the
> hardware will trigger a reset soon. At this time we should return an
> error code instead of 0, and HCLGE_STATE_CMD_DISABLE needs to be set to
> prevent sending command again.
> 
> Fixes: 3ff504908f95 ("net: hns3: fix a dead loop in hclge_cmd_csq_clean")
> Signed-off-by: Huazhong Tan <tanhuazhong@...wei.com>wq
            --->                                      ^^^

I think I know what text editor you use... :-)

Applied with 'wq' removed from your signoff... Thanks.