netdev - Re: [PATCH net-next 1/3] ip: discard IPv4 datagrams with overlapping segments.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180802155446.604d1a9b@xeon-e3>
Date:   Thu, 2 Aug 2018 15:54:46 -0700
From:   Stephen Hemminger <stephen@...workplumber.org>
To:     Peter Oskolkov <posk@...gle.com>
Cc:     David Miller <davem@...emloft.net>, netdev@...r.kernel.org,
        Eric Dumazet <edumazet@...gle.com>,
        Florian Westphal <fw@...len.de>
Subject: Re: [PATCH net-next 1/3] ip: discard IPv4 datagrams with
 overlapping segments.

On Thu,  2 Aug 2018 22:45:58 +0000
Peter Oskolkov <posk@...gle.com> wrote:

> diff --git a/include/uapi/linux/snmp.h b/include/uapi/linux/snmp.h
> index e5ebc83827ab..da1a144f1a51 100644
> --- a/include/uapi/linux/snmp.h
> +++ b/include/uapi/linux/snmp.h
> @@ -40,6 +40,7 @@ enum
>  	IPSTATS_MIB_REASMREQDS,			/* ReasmReqds */
>  	IPSTATS_MIB_REASMOKS,			/* ReasmOKs */
>  	IPSTATS_MIB_REASMFAILS,			/* ReasmFails */
> +	IPSTATS_MIB_REASM_OVERLAPS,		/* ReasmOverlaps */
>  	IPSTATS_MIB_FRAGOKS,			/* FragOKs */
>  	IPSTATS_MIB_FRAGFAILS,			/* FragFails */
>  	IPSTATS_MIB_FRAGCREATES,		/* FragCreates */

Inserting new entries in the middle of an enum means the numeric
values will change. Isn't this going to break userspace ABI?