netdev - Re: [PATCH v2] net: fec: check DMA addressing limitations

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <e03a908e-4c0d-a295-90a7-2da11c8fead5@arm.com>
Date:   Thu, 2 Aug 2018 10:19:20 +0100
From:   Robin Murphy <robin.murphy@....com>
To:     Stefan Agner <stefan@...er.ch>, fugang.duan@....com,
        davem@...emloft.net
Cc:     krzk@...nel.org, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] net: fec: check DMA addressing limitations

On 2018-08-02 9:42 AM, Stefan Agner wrote:
> Check DMA addressing limitations as suggested by the DMA API
> how-to. This does not fix a particular issue seen but is
> considered good style.

Reviewed-by: Robin Murphy <robin.murphy@....com>

> Signed-off-by: Stefan Agner <stefan@...er.ch>
> ---
>   drivers/net/ethernet/freescale/fec_main.c | 8 ++++++++
>   1 file changed, 8 insertions(+)
> 
> diff --git a/drivers/net/ethernet/freescale/fec_main.c b/drivers/net/ethernet/freescale/fec_main.c
> index c729665107f5..cdf2f5447910 100644
> --- a/drivers/net/ethernet/freescale/fec_main.c
> +++ b/drivers/net/ethernet/freescale/fec_main.c
> @@ -3136,6 +3136,7 @@ static int fec_enet_init(struct net_device *ndev)
>   	unsigned dsize = fep->bufdesc_ex ? sizeof(struct bufdesc_ex) :
>   			sizeof(struct bufdesc);
>   	unsigned dsize_log2 = __fls(dsize);
> +	int ret;
>   
>   	WARN_ON(dsize != (1 << dsize_log2));
>   #if defined(CONFIG_ARM) || defined(CONFIG_ARM64)
> @@ -3146,6 +3147,13 @@ static int fec_enet_init(struct net_device *ndev)
>   	fep->tx_align = 0x3;
>   #endif
>   
> +	/* Check mask of the streaming and coherent API */
> +	ret = dma_set_mask_and_coherent(&fep->pdev->dev, DMA_BIT_MASK(32));
> +	if (ret < 0) {
> +		dev_warn(&fep->pdev->dev, "No suitable DMA available\n");
> +		return ret;
> +	}
> +
>   	fec_enet_alloc_queue(ndev);
>   
>   	bd_size = (fep->total_tx_ring_size + fep->total_rx_ring_size) * dsize;
>