netdev - Re: [PATCH v2 net-next 5/9] net: stmmac: Add MDIO related functions for XGMAC2

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20180803153046.GE15029@lunn.ch>
Date:   Fri, 3 Aug 2018 17:30:46 +0200
From:   Andrew Lunn <andrew@...n.ch>
To:     Jose Abreu <Jose.Abreu@...opsys.com>
Cc:     netdev@...r.kernel.org, "David S. Miller" <davem@...emloft.net>,
        Joao Pinto <Joao.Pinto@...opsys.com>,
        Giuseppe Cavallaro <peppe.cavallaro@...com>,
        Alexandre Torgue <alexandre.torgue@...com>
Subject: Re: [PATCH v2 net-next 5/9] net: stmmac: Add MDIO related functions
 for XGMAC2

> > Probably you want to wait for the bus to be idle before you change the
> > mode to C22. Some PHYs can do both C22 and C45, e.g. EEE registers can
> > be in C45 space, while the rest are in C22.
> 
> Ok but I can't test C45 right now so maybe leave that change to
> when I can test it ?

I would fix this now. It probably cannot cause issues now, but it is
wrong. You are going to have to fix it some time, so why not now?

       Andrew