netdev - Re: [PATCH net-next 0/3] l2tp: sanitise MTU handling on sessions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20180803.100422.716736599661874064.davem@davemloft.net>
Date:   Fri, 03 Aug 2018 10:04:22 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     g.nault@...halink.fr
Cc:     netdev@...r.kernel.org, jchapman@...alix.com
Subject: Re: [PATCH net-next 0/3] l2tp: sanitise MTU handling on sessions

From: Guillaume Nault <g.nault@...halink.fr>
Date: Fri, 3 Aug 2018 12:38:32 +0200

> Most of the code handling sessions' MTU has no effect. The ->mtu field
> in struct l2tp_session might be used at session creation time, but
> neither PPP nor Ethernet pseudo-wires take updates into account.
> 
> L2TP sessions don't have a concept of MTU, which is the reason why
> ->mtu is mostly ignored. MTU should remain a network device thing.
> Therefore this patch set does not try to propagate/update ->mtu to/from
> the device. That would complicate the code unnecessarily. Instead this
> field and the associated ioctl commands and netlink attributes are
> removed.
> 
> Patch #1 defines l2tp_tunnel_dst_mtu() in order to simplify the
> following patches. Then patches #2 and #3 remove MTU handling from PPP
> and Ethernet pseudo-wires respectively.

Series applied, thanks.