netdev - Re: [PATCH v2 1/2] net/sctp: Make wrappers for accessing in/out streams

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 03 Aug 2018 12:50:00 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     khorenko@...tuozzo.com
Cc:     marcelo.leitner@...il.com, oleg.babin@...il.com,
        netdev@...r.kernel.org, linux-sctp@...r.kernel.org,
        vyasevich@...il.com, nhorman@...driver.com, lucien.xin@...il.com,
        aryabinin@...tuozzo.com
Subject: Re: [PATCH v2 1/2] net/sctp: Make wrappers for accessing in/out
 streams

From: Konstantin Khorenko <khorenko@...tuozzo.com>
Date: Fri,  3 Aug 2018 19:21:01 +0300

> +struct sctp_stream_out *sctp_stream_out(const struct sctp_stream *stream,
> +					__u16 sid)
> +{
> +	return ((struct sctp_stream_out *)(stream->out)) + sid;
> +}
> +
> +struct sctp_stream_in *sctp_stream_in(const struct sctp_stream *stream,
> +				      __u16 sid)
> +{
> +	return ((struct sctp_stream_in *)(stream->in)) + sid;
> +}

I agree with David that these should be in a header file, and marked
inline.