netdev - Re: [PATCH nf-next v2 1/1] ipv6: defrag: drop non-last frags smaller than min mtu

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20180802171403.58a5e561@xeon-e3>
Date:   Thu, 2 Aug 2018 17:14:03 -0700
From:   Stephen Hemminger <stephen@...workplumber.org>
To:     Florian Westphal <fw@...len.de>
Cc:     <netdev@...r.kernel.org>, Peter Oskolkov <posk@...gle.com>,
        Eric Dumazet <edumazet@...gle.com>
Subject: Re: [PATCH nf-next v2 1/1] ipv6: defrag: drop non-last frags
 smaller than min mtu

On Fri,  3 Aug 2018 02:05:39 +0200
Florian Westphal <fw@...len.de> wrote:

> +	if (-skb_network_offset(skb) + skb->len < IPV6_MIN_MTU &&

Is there a reason to write the arithmetic expression in this order?
Why not:
	if (skb->len - skb_network_offset(skb) < IPV6_MIN_MTU &&