netdev - Re: [PATCH v8 bpf-next 04/10] xdp: Helper function to clear kernel pointers in xdp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180803110610.5f3235f8@redhat.com>
Date:   Fri, 3 Aug 2018 11:06:10 +0200
From:   Jesper Dangaard Brouer <brouer@...hat.com>
To:     Toshiaki Makita <makita.toshiaki@....ntt.co.jp>
Cc:     Alexei Starovoitov <ast@...nel.org>,
        Daniel Borkmann <daniel@...earbox.net>, netdev@...r.kernel.org,
        Jakub Kicinski <jakub.kicinski@...ronome.com>,
        John Fastabend <john.fastabend@...il.com>, brouer@...hat.com
Subject: Re: [PATCH v8 bpf-next 04/10] xdp: Helper function to clear kernel
 pointers in xdp_frame

On Fri,  3 Aug 2018 16:58:12 +0900
Toshiaki Makita <makita.toshiaki@....ntt.co.jp> wrote:

> xdp_frame has kernel pointers which should not be readable from bpf
> programs. When we want to reuse xdp_frame region but it may be read by
> bpf programs later, we can use this helper to clear kernel pointers.
> This is more efficient than calling memset() for the entire struct.
> 
> Signed-off-by: Toshiaki Makita <makita.toshiaki@....ntt.co.jp>

Acked-by: Jesper Dangaard Brouer <brouer@...hat.com>

After this patch is applied, I will take care of updating cpumap in a
similar way. Thanks.

-- 
Best regards,
  Jesper Dangaard Brouer
  MSc.CS, Principal Kernel Engineer at Red Hat
  LinkedIn: http://www.linkedin.com/in/brouer