netdev - Re: for newbies, it would be useful to document values of netdev_state

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <bc33b6c0-6dbc-9d63-e798-b999b7601c3b@gmail.com>
Date:   Sat, 4 Aug 2018 11:10:34 -0700
From:   Florian Fainelli <f.fainelli@...il.com>
To:     "Robert P. J. Day" <rpjday@...shcourse.ca>,
        Linux kernel ntedev mailing list <netdev@...r.kernel.org>
Subject: Re: for newbies, it would be useful to document values of
 netdev_state_t



On 08/04/2018 08:30 AM, Robert P. J. Day wrote:
> 
>   i'm sure this is second nature for the experts here, but in
> netdevice.h:
> 
> /* These flag bits are private to the generic network queueing
>  * layer; they may not be explicitly referenced by any other
>  * code.
>  */
> 
> enum netdev_state_t {
>         __LINK_STATE_START,
>         __LINK_STATE_PRESENT,
>         __LINK_STATE_NOCARRIER,
>         __LINK_STATE_LINKWATCH_PENDING,
>         __LINK_STATE_DORMANT,
> };
> 
> it would be handy to have a short explanation of what each state
> represents, perhaps what combinations are possible and how one moves
> from one state to another.

This has been like that for some time, and with the exception of the
problem you reported in your email before that one, people generally
don't muck with that enum, or the state machine consuming it. There
might be other places that could deserve better documentation ;)
-- 
Florian