netdev - Re: [PATCH net-next] ethtool: Remove trailing semicolon for static inline

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Sat, 04 Aug 2018 14:56:49 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     f.fainelli@...il.com
Cc:     netdev@...r.kernel.org
Subject: Re: [PATCH net-next] ethtool: Remove trailing semicolon for static
 inline

From: Florian Fainelli <f.fainelli@...il.com>
Date: Sat,  4 Aug 2018 14:20:40 -0700

> Android's header sanitization tool chokes on static inline functions having a
> trailing semicolon, leading to an incorrectly parsed header file. While the
> tool should obviously be fixed, also fix the header files for the two affected
> functions: ethtool_get_flow_spec_ring() and ethtool_get_flow_spec_ring_vf().
> 
> Fixes: 8cf6f497de40 ("ethtool: Add helper routines to pass vf to rx_flow_spec")
> Reporetd-by: Blair Prescott <blair.prescott@...adcom.com>
> Signed-off-by: Florian Fainelli <f.fainelli@...il.com>

Applied, thanks Florian.

Trailing semicolon removal has become so trendy all of a sudden...