netdev - Re: [PATCH] net: cisco: enic: Replace GFP_ATOMIC with GFP

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sat, 4 Aug 2018 00:54:15 +0000
From:   "Govindarajulu Varadarajan (gvaradar)" <gvaradar@...co.com>
To:     "baijiaju1990@...il.com" <baijiaju1990@...il.com>,
        "_govind@....com" <_govind@....com>,
        "Christian Benvenuti (benve)" <benve@...co.com>,
        "Parvi Kaustubhi (pkaustub)" <pkaustub@...co.com>
CC:     "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] net: cisco: enic: Replace GFP_ATOMIC with GFP_KERNEL

On Sat, 2018-08-04 at 08:40 +0800, Jia-Ju Bai wrote:
> vnic_dev_register(), vnic_rq_alloc_bufs() and vnic_wq_alloc_bufs() 
> are never called in atomic context.
> They call kzalloc() with GFP_ATOMIC, which is not necessary.
> GFP_ATOMIC can be replaced with GFP_KERNEL.
> 
> This is found by a static analysis tool named DCNS written by myself.

Looks good to me. Thanks you.

Acked-by: Govindarajulu Varadarajan <gvaradar@...co.com>