netdev - Re: [PATCH] netlink: Don't shift on 64 for ngroups

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1533429429.2679.156.camel@arista.com>
Date:   Sun, 05 Aug 2018 01:37:09 +0100
From:   Dmitry Safonov <dima@...sta.com>
To:     David Miller <davem@...emloft.net>
Cc:     linux-kernel@...r.kernel.org, natechancellor@...il.com,
        herbert@...dor.apana.org.au, steffen.klassert@...unet.com,
        netdev@...r.kernel.org, stable@...r.kernel.org
Subject: Re: [PATCH] netlink: Don't shift on 64 for ngroups

On Sat, 2018-08-04 at 17:08 -0700, David Miller wrote:
> From: Dmitry Safonov <dima@...sta.com>
> Date: Sun,  5 Aug 2018 00:55:44 +0100
> 
> > @@ -1011,8 +1011,8 @@ static int netlink_bind(struct socket *sock,
> struct sockaddr *addr,
> >  
> >       if (nlk->ngroups == 0)
> >               groups = 0;
> > -     else
> > -             groups &= (1ULL << nlk->ngroups) - 1;
> > +     else if (nlk->ngroups < sizeof(long unsigned int))
> > +             groups &= (1UL << nlk->ngroups) - 1;
> 
> Sizeof is in bytes, you want to compare against bits.

I'm too bad. Drop this version, please.
I've resent v2.