netdev - Re: [PATCH net] ip6_tunnel: use the right value for ipv4 min mtu check in ip6_tnl

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Sun, 05 Aug 2018 17:35:46 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     lucien.xin@...il.com
Cc:     netdev@...r.kernel.org, sd@...asysnail.net
Subject: Re: [PATCH net] ip6_tunnel: use the right value for ipv4 min mtu
 check in ip6_tnl_xmit

From: Xin Long <lucien.xin@...il.com>
Date: Sun,  5 Aug 2018 22:46:07 +0800

> According to RFC791, 68 bytes is the minimum size of IPv4 datagram every
> device must be able to forward without further fragmentation while 576
> bytes is the minimum size of IPv4 datagram every device has to be able
> to receive, so in ip6_tnl_xmit(), 68(IPV4_MIN_MTU) should be the right
> value for the ipv4 min mtu check in ip6_tnl_xmit.
> 
> While at it, change to use max() instead of if statement.
> 
> Fixes: c9fefa08190f ("ip6_tunnel: get the min mtu properly in ip6_tnl_xmit")
> Reported-by: Sabrina Dubroca <sd@...asysnail.net>
> Signed-off-by: Xin Long <lucien.xin@...il.com>

Applied and queued up for -stable, thanks Xin.