netdev - Re: [PATCH] net/bridge/br_multicast: remove redundant variable "err"

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <5B67AF40.70504@huawei.com>
Date:   Mon, 6 Aug 2018 10:15:28 +0800
From:   zhong jiang <zhongjiang@...wei.com>
To:     David Miller <davem@...emloft.net>
CC:     <stephen@...workplumber.org>, <netdev@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] net/bridge/br_multicast: remove redundant variable "err"

On 2018/8/6 8:33, David Miller wrote:
> From: zhong jiang <zhongjiang@...wei.com>
> Date: Sun, 5 Aug 2018 22:18:43 +0800
>
>> @@ -1797,7 +1795,7 @@ static int br_multicast_ipv4_rcv(struct net_bridge *br,
>>  	struct sk_buff *skb_trimmed = NULL;
>>  	const unsigned char *src;
>>  	struct igmphdr *ih;
>> -	int err;
>> +	int err = 0;
>>  
>>  	err = ip_mc_check_igmp(skb, &skb_trimmed);
> The initialization of err to '0' is unnecessary, it gets assigned on
> the very next line.
>
> .
>
 That's right.  I will drop that change and repost.

Thanks,
zhong jiang