netdev - Re: [PATCH v8 bpf-next 00/10] veth: Driver XDP

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <82583528-9c49-5db8-db11-04d501ca0bfc@intel.com>
Date:   Mon, 6 Aug 2018 10:22:10 +0200
From:   Björn Töpel <bjorn.topel@...el.com>
To:     Jesper Dangaard Brouer <brouer@...hat.com>,
        Toshiaki Makita <makita.toshiaki@....ntt.co.jp>
Cc:     Alexei Starovoitov <ast@...nel.org>,
        Daniel Borkmann <daniel@...earbox.net>, netdev@...r.kernel.org,
        Jakub Kicinski <jakub.kicinski@...ronome.com>,
        John Fastabend <john.fastabend@...il.com>,
        Tariq Toukan <tariqt@...lanox.com>,
        Björn Töpel <bjorn.topel@...il.com>,
        intel-wired-lan@...ts.osuosl.org
Subject: Re: [PATCH v8 bpf-next 00/10] veth: Driver XDP

On 2018-08-03 11:45, Jesper Dangaard Brouer wrote:
> On Fri,  3 Aug 2018 16:58:08 +0900
> Toshiaki Makita <makita.toshiaki@....ntt.co.jp> wrote:
> 
>> This patch set introduces driver XDP for veth.
>> Basically this is used in conjunction with redirect action of another XDP
>> program.
>>
>>    NIC -----------> veth===veth
>>   (XDP) (redirect)        (XDP)
>>
> 
> I'm was playing with V7 on my testlab yesterday and I noticed one
> fundamental issue.  You are not updating the "ifconfig" stats counters,
> when in XDP mode.  This makes receive or send via XDP invisible to
> sysadm/management tools.  This for-sure is going to cause confusion...
> 
> I took a closer look at other driver. The ixgbe driver is doing the
> right thing.  Driver i40e have a bug, where RX/TX stats are swapped
> getting (strange!).  

Indeed! Thanks for finding/reporting this! I'll have look!


Björn

> The mlx5 driver is not updating the regular RX/TX
> counters, but A LOT of other ethtool stats counters (which are the ones
> I usually monitor when testing).
> 
> So, given other drivers also didn't get this right, we need to have a
> discussion outside your/this patchset.  Thus, I don't want to
> stop/stall this patchset, but this is something we need to fixup in a
> followup patchset to other drivers as well.
> 
> Thus, I'm acking the patchset, but I request that we do a joint effort
> of fixing this as followup patches.
> 
> Acked-by: Jesper Dangaard Brouer <brouer@...hat.com>
>