netdev - Re: [PATCH] mellanox: fix the dport endianness in call of __inet6_lookup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <fe8a40c7-b64e-48bc-33e2-79a8898e8575@mellanox.com>
Date:   Mon, 6 Aug 2018 12:23:28 +0300
From:   Boris Pismenny <borisp@...lanox.com>
To:     David Miller <davem@...emloft.net>, viro@...IV.linux.org.uk
Cc:     netdev@...r.kernel.org
Subject: Re: [PATCH] mellanox: fix the dport endianness in call of
 __inet6_lookup_established()



On 8/6/2018 3:27 AM, David Miller wrote:
> From: Al Viro <viro@...IV.linux.org.uk>
> Date: Sat, 4 Aug 2018 21:41:27 +0100
> 
>> __inet6_lookup_established() expect th->dport passed in host-endian,
>> not net-endian.  The reason is microoptimization in __inet6_lookup(),
>> but if you use the lower-level helpers, you have to play by their
>> rules...
>>      
>> Signed-off-by: Al Viro <viro@...iv.linux.org.uk>
> 
> Mellanox folks, please review.
> 

Looks good to me. Thanks Al.