netdev - Re: [PATCH net-next] ip6_tunnel: collect_md xmit: Use ip_tunnel

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20180807.123719.1020396637013549448.davem@davemloft.net>
Date:   Tue, 07 Aug 2018 12:37:19 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     shmulik@...anetworks.com
Cc:     ast@...nel.org, netdev@...r.kernel.org, shmulik.ladkani@...il.com
Subject: Re: [PATCH net-next] ip6_tunnel: collect_md xmit: Use
 ip_tunnel_key's provided src address

From: Shmulik Ladkani <shmulik@...anetworks.com>
Date: Mon,  6 Aug 2018 15:00:59 +0300

> When using an ip6tnl device in collect_md mode, the xmit methods ignore
> the ipv6.src field present in skb_tunnel_info's key, both for route
> calculation purposes (flowi6 construction) and for assigning the
> packet's final ipv6h->saddr.
> 
> This makes it impossible specifying a desired ipv6 local address in the
> encapsulating header (for example, when using tc action tunnel_key).
> 
> This is also not aligned with behavior of ipip (ipv4) in collect_md
> mode, where the key->u.ipv4.src gets used.
> 
> Fix, by assigning fl6.saddr with given key->u.ipv6.src.
> In case ipv6.src is not specified, ip6_tnl_xmit uses existing saddr
> selection code.

Applied, thanks.

> Signed-off-by: Shmulik Ladkani <shmulik.ladkani@...il.com>
> Reviewed-by: Eyal Birger <eyal.birger@...il.com>
> Fixes: 8d79266bc48c ("ip6_tunnel: add collect_md mode to IPv6 tunnels")

Please place the Fixes: tag first in the set of tags in the future,
thank you.