netdev - Re: [PATCH net-next 2/2] ibmvnic: Update firmware error reporting with cause string

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <4c6e57db-b5b7-fa9d-d3ef-9016dfe0be21@linux.vnet.ibm.com>
Date:   Mon, 6 Aug 2018 22:48:49 -0500
From:   Nathan Fontenot <nfont@...ux.vnet.ibm.com>
To:     Thomas Falcon <tlfalcon@...ux.vnet.ibm.com>, netdev@...r.kernel.org
Cc:     jallen@...ux.vnet.ibm.com
Subject: Re: [PATCH net-next 2/2] ibmvnic: Update firmware error reporting
 with cause string


On 08/06/2018 09:39 PM, Thomas Falcon wrote:
> Print a string instead of the error code. Since there is a
> possibility that the driver can recover, classify it as a
> warning instead of an error.
> 
> Signed-off-by: Thomas Falcon <tlfalcon@...ux.vnet.ibm.com>
> ---
>   drivers/net/ethernet/ibm/ibmvnic.c | 34 ++++++++++++++++++++++++++++++----
>   1 file changed, 30 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/net/ethernet/ibm/ibmvnic.c b/drivers/net/ethernet/ibm/ibmvnic.c
> index 109e4a58efad..dafdd4ade705 100644
> --- a/drivers/net/ethernet/ibm/ibmvnic.c
> +++ b/drivers/net/ethernet/ibm/ibmvnic.c
> @@ -3825,15 +3825,41 @@ static void handle_query_ip_offload_rsp(struct ibmvnic_adapter *adapter)
>   	ibmvnic_send_crq(adapter, &crq);
>   }
> 
> +static const char *ibmvnic_fw_err_cause(u16 cause)
> +{
> +	switch (cause) {
> +	case ADAPTER_PROBLEM:
> +		return "adapter problem";
> +	case BUS_PROBLEM:
> +		return "bus problem";
> +	case FW_PROBLEM:
> +		return "firmware problem";
> +	case DD_PROBLEM:
> +		return "device driver problem";
> +	case EEH_RECOVERY:
> +		return "EEH recovery";
> +	case FW_UPDATED:
> +		return "firmware updated";
> +	case LOW_MEMORY:
> +		return "low Memory";
> +	default:
> +		return "unknown";
> +	}
> +}
> +
>   static void handle_error_indication(union ibmvnic_crq *crq,
>   				    struct ibmvnic_adapter *adapter)
>   {
>   	struct device *dev = &adapter->vdev->dev;
> +	u16 cause;
> +
> +	cause = be16_to_cpu(crq->error_indication.error_cause);
> 
> -	dev_err(dev, "Firmware reports %serror, cause %d\n",
> -		crq->error_indication.flags
> -			& IBMVNIC_FATAL_ERROR ? "FATAL " : "",
> -		be16_to_cpu(crq->error_indication.error_cause));
> +	dev_warn_ratelimited(dev,
> +			     "Firmware reports %serror, cause: %s. Starting recovery...\n",

                                                ^^^^^^^

You're going to want a space between after the %s here.

-Nathan

> +			     crq->error_indication.flags
> +				& IBMVNIC_FATAL_ERROR ? "FATAL " : "",
> +			     ibmvnic_fw_err_cause(cause));
> 
>   	if (crq->error_indication.flags & IBMVNIC_FATAL_ERROR)
>   		ibmvnic_reset(adapter, VNIC_RESET_FATAL);
>