netdev - Re: [PATCH net-next] net: allow to call netif_reset_xps_queues() under cpu_read

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20180807.131506.1417943889767040945.davem@davemloft.net>
Date:   Tue, 07 Aug 2018 13:15:06 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     avagin@...nvz.org
Cc:     netdev@...r.kernel.org, virtualization@...ts.linux-foundation.org,
        avagin@...il.com, amritha.nambiar@...el.com, mst@...hat.com,
        jasowang@...hat.com
Subject: Re: [PATCH net-next] net: allow to call netif_reset_xps_queues()
 under cpu_read_lock

From: Andrei Vagin <avagin@...nvz.org>
Date: Mon,  6 Aug 2018 21:14:54 -0700

> This patch adds an ability to call __netif_set_xps_queue under
> cpu_read_lock().

Please don't add conditional locking using a boolean argument.

Simply wrap calls to __netif_set_xps_queue() with cpu read
lock held by the caller or similar.