netdev - Re: [PATCH ethtool 2/3] ethtool: Add support for WAKE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 8 Aug 2018 11:25:21 -0700
From:   Florian Fainelli <f.fainelli@...il.com>
To:     netdev@...r.kernel.org
Cc:     linville@...driver.com, andrew@...n.ch, davem@...emloft.net
Subject: Re: [PATCH ethtool 2/3] ethtool: Add support for WAKE_FILTER (WoL
 using filters)

On 08/08/2018 11:22 AM, Florian Fainelli wrote:
> Add a new character 'f' which can be used to configure an Ethernet
> controller to support Wake-on-LAN using filters programmed with the
> ethtool::rxnfc and the special action -2 (wake-up filter). This is
> useful in particular in the context of devices that must support wake-up
> on more complex patterns such as multicast DNS packets.
> 
> Signed-off-by: Florian Fainelli <f.fainelli@...il.com>
> ---
>  ethtool.8.in | 4 +++-
>  ethtool.c    | 5 +++++
>  2 files changed, 8 insertions(+), 1 deletion(-)
> 
> diff --git a/ethtool.8.in b/ethtool.8.in
> index 0a366aa536ae..97c7330fd373 100644
> --- a/ethtool.8.in
> +++ b/ethtool.8.in
> @@ -58,7 +58,7 @@
>  .\"
>  .\"	\(*WO - wol flags
>  .\"
> -.ds WO \fBp\fP|\fBu\fP|\fBm\fP|\fBb\fP|\fBa\fP|\fBg\fP|\fBs\fP|\fBd\fP...
> +.ds WO \fBp\fP|\fBu\fP|\fBm\fP|\fBb\fP|\fBa\fP|\fBg\fP|\fBs\fP|\fBf|\fBd\fP...
>  .\"
>  .\"	\(*FL - flow type values
>  .\"
> @@ -679,6 +679,7 @@ b	Wake on broadcast messages
>  a	Wake on ARP
>  g	Wake on MagicPacket\[tm]
>  s	Enable SecureOn\[tm] password for MagicPacket\[tm]
> +f	Wake on filter(s)
>  d	T{
>  Disable (wake on nothing).  This option clears all previous options.
>  T}
> @@ -870,6 +871,7 @@ Specifies the Rx queue to send packets to, or some other action.
>  nokeep;
>  lB	l.
>  -1	Drop the matched flow
> +-2	Use the matched flow as a Wake-on-LAN filter

Humm, this hunk belongs in patch #3, I will re-submit that series after
you give me some feedback. Thanks!
-- 
Florian