netdev - Question about inode_permission() check in unix_find

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-Id: <91367B74-6AC5-4E14-AE13-30FF6A7A6592@vt.edu>
Date:   Wed, 8 Aug 2018 18:09:57 -0700
From:   TongZhang <ztong@...edu>
To:     davem@...emloft.net, garsilva@...eddedor.com,
        matthew@...systems.ca, willemb@...gle.com, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org
Cc:     wenbo.s@...sung.com, ahmedmoneeb@...il.com
Subject: Question about inode_permission() check in unix_find_other()

Hi Networking Subsystem Maintainers,

I have a quick question about inode_permission() check in unix_find_other(),

I was doing a code review on net/unix/af_unix.c and found out that the inode_permission() check is confusing here.

Since the unix socket is presented as a file, and will be permission checked by VFS when user open it,
why do we still need the inode_permission() check in unix_find_other() anyway?

Thank you,
- Tong