netdev - Re: [PATCH net-next] net: ipv6_gre: Fix GRO to work on IPv6 over GRE tap

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20180809.140810.1435534399922642865.davem@davemloft.net>
Date:   Thu, 09 Aug 2018 14:08:10 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     tariqt@...lanox.com
Cc:     netdev@...r.kernel.org, eranbe@...lanox.com, mariap@...lanox.com
Subject: Re: [PATCH net-next] net: ipv6_gre: Fix GRO to work on IPv6 over
 GRE tap

From: Tariq Toukan <tariqt@...lanox.com>
Date: Wed,  8 Aug 2018 11:46:30 +0300

> IPv6 GRO over GRE tap is not working while GRO is not set
> over the native interface.
 ...
> This patch removes the override of the hard_header_len, and
> assigns the calculated value to needed_headroom.
> This way, the comparison in gro_list_prepare is really of
> the mac headers, and if the packets have the same mac headers
> the same_flow will be set to 1.
> 
> Performance testing: 45% higher bandwidth.
> Measuring bandwidth of single-stream IPv4 TCP traffic over IPv6
> GRE tap while GRO is not set on the native.
> NIC: ConnectX-4LX
> Before (GRO not working) : 7.2 Gbits/sec
> After (GRO working): 10.5 Gbits/sec
> 
> Signed-off-by: Maria Pasechnik <mariap@...lanox.com>
> Signed-off-by: Tariq Toukan <tariqt@...lanox.com>

Applied, thank you.