netdev - Re: [PATCH] net: dsa: rtl8366rb: Support port 4 (WAN)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20180809.141520.1650435824929049081.davem@davemloft.net>
Date:   Thu, 09 Aug 2018 14:15:20 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     linus.walleij@...aro.org
Cc:     andrew@...n.ch, vivien.didelot@...oirfairelinux.com,
        f.fainelli@...il.com, netdev@...r.kernel.org,
        openwrt-devel@...ts.openwrt.org, lede-dev@...ts.infradead.org
Subject: Re: [PATCH] net: dsa: rtl8366rb: Support port 4 (WAN)

From: Linus Walleij <linus.walleij@...aro.org>
Date: Wed,  8 Aug 2018 14:38:55 +0200

> The totally undocumented IO mode needs to be set to enumerator
> 0 to enable port 4 also known as WAN in most configurations,
> for ordinary traffic. The 3 bits in the register come up as
> 010 after reset, but need to be set to 000.
> 
> The Realtek source code contains a name for these bits, but
> no explanation of what the 8 different IO modes may be.
> 
> Set it to zero for the time being and drop a comment so
> people know what is going on if they run into trouble. This
> "mode zero" works fine with the D-Link DIR-685 with
> RTL8366RB.
> 
> Signed-off-by: Linus Walleij <linus.walleij@...aro.org>

Applied to net-next, thank you.