netdev - Re: [PATCH net-next v2] net: allow to call netif_reset_xps_queues() under cpus_read

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20180809.142624.1844562537465532129.davem@davemloft.net>
Date:   Thu, 09 Aug 2018 14:26:24 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     avagin@...nvz.org
Cc:     netdev@...r.kernel.org, avagin@...il.com,
        amritha.nambiar@...el.com, mst@...hat.com, jasowang@...hat.com
Subject: Re: [PATCH net-next v2] net: allow to call
 netif_reset_xps_queues() under cpus_read_lock

From: Andrei Vagin <avagin@...nvz.org>
Date: Wed,  8 Aug 2018 20:07:35 -0700

> From: Andrei Vagin <avagin@...il.com>
> 
> The definition of static_key_slow_inc() has cpus_read_lock in place. In the
> virtio_net driver, XPS queues are initialized after setting the queue:cpu
> affinity in virtnet_set_affinity() which is already protected within
> cpus_read_lock. Lockdep prints a warning when we are trying to acquire
> cpus_read_lock when it is already held.
> 
> This patch adds an ability to call __netif_set_xps_queue under
> cpus_read_lock().
 ...

Applied, thank you.