netdev - Re: [PATCH net-next] mlxsw: core: remove unnecessary function mlxsw_core_driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180810152631.GB11917@splinter.mtl.com>
Date:   Fri, 10 Aug 2018 18:26:31 +0300
From:   Ido Schimmel <idosch@...lanox.com>
To:     YueHaibing <yuehaibing@...wei.com>
Cc:     davem@...emloft.net, jiri@...lanox.com,
        linux-kernel@...r.kernel.org, netdev@...r.kernel.org
Subject: Re: [PATCH net-next] mlxsw: core: remove unnecessary function
 mlxsw_core_driver_put

On Fri, Aug 10, 2018 at 10:37:30AM +0800, YueHaibing wrote:
> The function mlxsw_core_driver_put only traverse mlxsw_core_driver_list
> to find the matched mlxsw_driver,but never used it.
> So it can be removed safely.
> 
> Signed-off-by: YueHaibing <yuehaibing@...wei.com>

Reviewed-by: Ido Schimmel <idosch@...lanox.com>

FWIW, this function used to call module_put(), but it was removed in
commit 1d20d23c59c9 ("mlxsw: Move PCI id table definitions into driver
modules").

Thanks!