lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 10 Aug 2018 18:17:47 +0200 From: Bartosz Golaszewski <brgl@...ev.pl> To: Andy Shevchenko <andy.shevchenko@...il.com> Cc: Jonathan Corbet <corbet@....net>, Sekhar Nori <nsekhar@...com>, Kevin Hilman <khilman@...nel.org>, Russell King <linux@...linux.org.uk>, Arnd Bergmann <arnd@...db.de>, Greg Kroah-Hartman <gregkh@...uxfoundation.org>, David Woodhouse <dwmw2@...radead.org>, Brian Norris <computersforpeace@...il.com>, Boris Brezillon <boris.brezillon@...tlin.com>, Marek Vasut <marek.vasut@...il.com>, Richard Weinberger <richard@....at>, Grygorii Strashko <grygorii.strashko@...com>, "David S . Miller" <davem@...emloft.net>, Srinivas Kandagatla <srinivas.kandagatla@...aro.org>, Naren <naren.kernel@...il.com>, Mauro Carvalho Chehab <mchehab+samsung@...nel.org>, Andrew Morton <akpm@...ux-foundation.org>, Lukas Wunner <lukas@...ner.de>, Dan Carpenter <dan.carpenter@...cle.com>, Florian Fainelli <f.fainelli@...il.com>, Ivan Khoronzhuk <ivan.khoronzhuk@...aro.org>, Sven Van Asbroeck <svendev@...x.com>, Paolo Abeni <pabeni@...hat.com>, Alban Bedel <albeu@...e.fr>, Rob Herring <robh@...nel.org>, David Lechner <david@...hnology.com>, Andrew Lunn <andrew@...n.ch>, Linux Documentation List <linux-doc@...r.kernel.org>, Linux Kernel Mailing List <linux-kernel@...r.kernel.org>, linux-arm Mailing List <linux-arm-kernel@...ts.infradead.org>, linux-i2c <linux-i2c@...r.kernel.org>, "open list:MEMORY TECHNOLOGY..." <linux-mtd@...ts.infradead.org>, Linux OMAP Mailing List <linux-omap@...r.kernel.org>, netdev <netdev@...r.kernel.org>, Bartosz Golaszewski <bgolaszewski@...libre.com> Subject: Re: [PATCH v2 14/29] net: simplify eth_platform_get_mac_address() 2018-08-10 16:39 GMT+02:00 Andy Shevchenko <andy.shevchenko@...il.com>: > On Fri, Aug 10, 2018 at 11:05 AM, Bartosz Golaszewski <brgl@...ev.pl> wrote: >> From: Bartosz Golaszewski <bgolaszewski@...libre.com> >> >> We don't need to use pci_device_to_OF_node() - we can retrieve >> dev->of_node directly even for pci devices. >> > >> struct device_node *dp; >> >> - if (dev_is_pci(dev)) >> - dp = pci_device_to_OF_node(to_pci_dev(dev)); >> - else >> - dp = dev->of_node; >> - >> + dp = dev->of_node; >> addr = NULL; >> if (dp) >> addr = of_get_mac_address(dp); > > Looking more at this I could even propose to change all above by > > addr = device_get_mac_address(dev, mac_addr, ETH_ALEN); > > Thoughts? > > -- > With Best Regards, > Andy Shevchenko Indeed seems like it's even more generalized. Thanks for spotting that. Bart
Powered by blists - more mailing lists