netdev - Re: [PATCH][net-next] packet: switch kvzalloc to allocate memory

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 10 Aug 2018 10:43:31 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     lirongqing@...du.com
Cc:     netdev@...r.kernel.org
Subject: Re: [PATCH][net-next] packet: switch kvzalloc to allocate memory

From: Li RongQing <lirongqing@...du.com>
Date: Fri, 10 Aug 2018 18:00:00 +0800

> @@ -4275,7 +4259,7 @@ static int packet_set_ring(struct sock *sk, union tpacket_req_u *req_u,
>  
>  		err = -ENOMEM;
>  		order = get_order(req->tp_block_size);
> -		pg_vec = alloc_pg_vec(req, order);
> +		pg_vec = alloc_pg_vec(req);
>  		if (unlikely(!pg_vec))
>  			goto out;
>  		switch (po->tp_version) {

Variable 'order' is now unused.