netdev - Re: [PATCH net-next 1/2] ip: add helpers to process in-order fragments faster.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20180811.122248.628104363689119106.davem@davemloft.net>
Date:   Sat, 11 Aug 2018 12:22:48 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     posk@...gle.com
Cc:     netdev@...r.kernel.org, edumazet@...gle.com, fw@...len.de
Subject: Re: [PATCH net-next 1/2] ip: add helpers to process in-order
 fragments faster.

From: Peter Oskolkov <posk@...gle.com>
Date: Fri, 10 Aug 2018 16:22:45 +0000

> This patch introduces several helper functions/macros that will be
> used in the follow-up patch. No runtime changes yet.
> 
> The new logic (fully implemented in the second patch) is as follows:
> 
> * Nodes in the rb-tree will now contain not single fragments, but lists
>   of consecutive fragments ("runs").
> 
> * At each point in time, the current "active" run at the tail is
>   maintained/tracked. Fragments that arrive in-order, adjacent
>   to the previous tail fragment, are added to this tail run without
>   triggering the re-balancing of the rb-tree.
> 
> * If a fragment arrives out of order with the offset _before_ the tail run,
>   it is inserted into the rb-tree as a single fragment.
> 
> * If a fragment arrives after the current tail fragment (with a gap),
>   it starts a new "tail" run, as is inserted into the rb-tree
>   at the end as the head of the new run.
> 
> skb->cb is used to store additional information
> needed here (suggested by Eric Dumazet).
> 
> Reported-by: Willem de Bruijn <willemb@...gle.com>
> Cc: Eric Dumazet <edumazet@...gle.com>
> Cc: Cc: Florian Westphal <fw@...len.de>

You need to post these changes with proper Signed-off-by: tags.