netdev - Re: [net-next 01/12] net/mlx5e: Ethtool steering flow validation refactoring

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20180810.192240.1330017327573643390.davem@davemloft.net>
Date:   Fri, 10 Aug 2018 19:22:40 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     saeedm@...lanox.com
Cc:     netdev@...r.kernel.org
Subject: Re: [net-next 01/12] net/mlx5e: Ethtool steering flow validation
 refactoring

From: Saeed Mahameed <saeedm@...lanox.com>
Date: Fri, 10 Aug 2018 15:26:19 -0700

> +static int validate_tcpudp4(struct ethtool_rx_flow_spec *fs)
> +{
> +	struct ethtool_tcpip4_spec *l4_mask = &fs->m_u.tcp_ip4_spec;
> +	int ntuples = 0;
> +
> +	if (fs->m_u.tcp_ip4_spec.tos)
            ^^^^^^^^^^^^^^^^^^^^^^^^

Since you've gone to the trouble of loading this object into
l4_mask before this statement, please use "if (l4_mask->tos)"

I know you're just moving existing code into a function, but it
looks silly now.