netdev - Re: [PATCH net-next] cpumask: make cpumask_next

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAF=yD-+EUWGhciqQbkK9dmbuwU_8zTUNisCeS=K1m6oU=dBY=w@mail.gmail.com>
Date:   Sun, 12 Aug 2018 13:15:35 +0200
From:   Willem de Bruijn <willemdebruijn.kernel@...il.com>
To:     Network Development <netdev@...r.kernel.org>
Cc:     David Miller <davem@...emloft.net>, caleb.raitto@...il.com,
        kbuild test robot <lkp@...el.com>,
        Willem de Bruijn <willemb@...gle.com>
Subject: Re: [PATCH net-next] cpumask: make cpumask_next_wrap available
 without smp

On Sun, Aug 12, 2018 at 11:20 AM Willem de Bruijn
<willemdebruijn.kernel@...il.com> wrote:
>
> From: Willem de Bruijn <willemb@...gle.com>
>
> The kbuild robot shows build failure on machines without CONFIG_SMP:
>
>   drivers/net/virtio_net.c:1916:10: error:
>     implicit declaration of function 'cpumask_next_wrap'
>
> cpumask_next_wrap is exported from lib/cpumask.o, which has
>
>     lib-$(CONFIG_SMP) += cpumask.o
>
> same as other functions, also define it as static inline in the
> NR_CPUS==1 branch in include/linux/cpumask.h.
>
> If wrap is false, function wraps across the range of valid cpus,
> here [0]. If it is true, it returns nr_cpumask_bits, here 1.
>
> Fixes: 2ca653d607ce ("virtio_net: Stripe queue affinities across cores.")
> Signed-off-by: Willem de Bruijn <willemb@...gle.com>

Sent too hastily. If wrap is true and n == -1, it should still return 0.

Will send a v2.