netdev - Re: [PATCH] cxgb4: remove set but not used variable 'spd'

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 13 Aug 2018 14:50:44 +0800
From:   YueHaibing <yuehaibing@...wei.com>
To:     <ganeshgr@...lsio.com>, <davem@...emloft.net>
CC:     <linux-kernel@...r.kernel.org>, <netdev@...r.kernel.org>
Subject: Re: [PATCH] cxgb4: remove set but not used variable 'spd'

Sorry, this should be for net-next

On 2018/8/13 14:48, YueHaibing wrote:
> Fixes gcc '-Wunused-but-set-variable' warning:
> drivers/net/ethernet/chelsio/cxgb4/cxgb4_main.c: In function 'print_port_info':
> drivers/net/ethernet/chelsio/cxgb4/cxgb4_main.c:5147:14: warning:
>  variable 'spd' set but not used [-Wunused-but-set-variable]
> 
> variable 'spd' is set but not used since
> commit 547fd27241a8 ("cxgb4: Warn if device doesn't have enough PCI bandwidth")
> 
> Signed-off-by: YueHaibing <yuehaibing@...wei.com>
> ---
>  drivers/net/ethernet/chelsio/cxgb4/cxgb4_main.c | 8 --------
>  1 file changed, 8 deletions(-)
> 
> diff --git a/drivers/net/ethernet/chelsio/cxgb4/cxgb4_main.c b/drivers/net/ethernet/chelsio/cxgb4/cxgb4_main.c
> index 69590cf..961e3087 100644
> --- a/drivers/net/ethernet/chelsio/cxgb4/cxgb4_main.c
> +++ b/drivers/net/ethernet/chelsio/cxgb4/cxgb4_main.c
> @@ -5144,17 +5144,9 @@ static void print_port_info(const struct net_device *dev)
>  {
>  	char buf[80];
>  	char *bufp = buf;
> -	const char *spd = "";
>  	const struct port_info *pi = netdev_priv(dev);
>  	const struct adapter *adap = pi->adapter;
>  
> -	if (adap->params.pci.speed == PCI_EXP_LNKSTA_CLS_2_5GB)
> -		spd = " 2.5 GT/s";
> -	else if (adap->params.pci.speed == PCI_EXP_LNKSTA_CLS_5_0GB)
> -		spd = " 5 GT/s";
> -	else if (adap->params.pci.speed == PCI_EXP_LNKSTA_CLS_8_0GB)
> -		spd = " 8 GT/s";
> -
>  	if (pi->link_cfg.pcaps & FW_PORT_CAP32_SPEED_100M)
>  		bufp += sprintf(bufp, "100M/");
>  	if (pi->link_cfg.pcaps & FW_PORT_CAP32_SPEED_1G)
>