netdev - Re: [PATCH v2] xen-netfront: fix warn message as irq device name has '/'

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20180813.085201.1107715561650084682.davem@davemloft.net>
Date:   Mon, 13 Aug 2018 08:52:01 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     xiliang@...hat.com
Cc:     netdev@...r.kernel.org, xen-devel@...ts.xenproject.org,
        jgross@...e.com, boris.ostrovsky@...cle.com,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] xen-netfront: fix warn message as irq device name
 has '/'

From: Xiao Liang <xiliang@...hat.com>
Date: Sat, 11 Aug 2018 23:21:37 +0800

> There is a call trace generated after commit 2d408c0d4574b01b9ed45e02516888bf925e11a9(
> xen-netfront: fix queue name setting). There is no 'device/vif/xx-q0-tx' file found
> under /proc/irq/xx/.
> 
> This patch only picks up device type and id as its name.

This adds a compile warning:

drivers/net/xen-netfront.c: In function ‘xennet_init_queue’:
drivers/net/xen-netfront.c:1614:2: warning: ignoring return value of ‘kstrtoint’, declared with attribute warn_unused_result [-Wunused-result]
  kstrtoint(strrchr(queue->info->xbdev->nodename, '/') + 1, 10, &devid);
  ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~