netdev - Re: [PATCH 2/2] net: lan743x: fix building without CONFIG_PTP_1588

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20180813.204420.1246202084626536095.davem@davemloft.net>
Date:   Mon, 13 Aug 2018 20:44:20 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     arnd@...db.de
Cc:     bryan.whitehead@...rochip.com, UNGLinuxDriver@...rochip.com,
        netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/2] net: lan743x: fix building without
 CONFIG_PTP_1588_CLOCK

From: Arnd Bergmann <arnd@...db.de>
Date: Mon, 13 Aug 2018 23:19:22 +0200

> Building without CONFIG_PTP_1588_CLOCK results in multiple failures,
> this was obviously not well tested:
 ...
> Those #ifdef checks are hard to get right, replace them all with
> IS_ENABLED() checks that leave the same code visible to the compiler
> but let it optimize out the unused bits based on the configuration.
> 
> Fixes: 07624df1c9ef ("lan743x: lan743x: Add PTP support")
> Signed-off-by: Arnd Bergmann <arnd@...db.de>

Applied.