netdev - Re: [PATCH] bnxt_en: take coredump

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20180813.204657.372870473276503588.davem@davemloft.net>
Date:   Mon, 13 Aug 2018 20:46:57 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     arnd@...db.de
Cc:     michael.chan@...adcom.com, vasundhara-v.volam@...adcom.com,
        gospo@...adcom.com, scott.branden@...adcom.com,
        netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] bnxt_en: take coredump_record structure off stack

From: Arnd Bergmann <arnd@...db.de>
Date: Tue, 14 Aug 2018 00:12:45 +0200

> The bnxt_coredump_record structure is very long, causing a warning
> about possible stack overflow on 32-bit architectures:
> 
> drivers/net/ethernet/broadcom/bnxt/bnxt_ethtool.c: In function 'bnxt_get_coredump':
> drivers/net/ethernet/broadcom/bnxt/bnxt_ethtool.c:2989:1: error: the frame size of 1188 bytes is larger than 1024 bytes [-Werror=frame-larger-than=]
> 
> I could not see any reason to operate on an on-stack copy of the
> structure before copying it back into the caller-provided buffer, which
> also simplifies the code here.
> 
> Fixes: 6c5657d085ae ("bnxt_en: Add support for ethtool get dump.")
> Signed-off-by: Arnd Bergmann <arnd@...db.de>

Applied.